Skip to content

Test new error handling indicating when the sandbox is not found #540

Merged
0div merged 32 commits intomainfrom
return-error-indicating-that-the-sandbox-is-not-running-when-e2b-1327-test
Apr 25, 2025
Merged

Test new error handling indicating when the sandbox is not found #540
0div merged 32 commits intomainfrom
return-error-indicating-that-the-sandbox-is-not-running-when-e2b-1327-test

Conversation

@0div
Copy link
Copy Markdown
Contributor

@0div 0div commented Jan 16, 2025

Added a test in js-sdk for e2b-dev/infra#231

@linear
Copy link
Copy Markdown

linear bot commented Jan 16, 2025

E2B-1327 Return error indicating that the sandbox is not running when making requests from SDK

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 16, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 004caee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@0div 0div mentioned this pull request Jan 16, 2025
Merged
2 tasks
jakubno
jakubno requested changes Jan 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jakubno jakubno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do the same for Python?

Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
@0div @jakubno
Update packages/js-sdk/tests/sandbox/host.test.ts
55ecbaf 
Co-authored-by: Jakub Novák <jakub@e2b.dev>
jakubno
jakubno reviewed Jan 16, 2025
View reviewed changes
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
@0div
Copy link
Copy Markdown
Contributor Author

0div commented Jan 16, 2025

Could we do the same for Python?

This is more of an integration test rather than a unit test, do you think it's necessary?

@0div
Copy link
Copy Markdown
Contributor Author

0div commented Jan 16, 2025

Could we do the same for Python?

This is more of an integration test rather than a unit test, do you think it's necessary?

@jakubno maybe relevant to that comment: #519

jakubno
jakubno reviewed Jan 17, 2025
View reviewed changes
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
@0div 0div requested a review from mlejva as a code owner January 18, 2025 01:21
@ValentaTomas ValentaTomas added the Improvement Improvement for current functionality label Jan 18, 2025
@0div 0div force-pushed the return-error-indicating-that-the-sandbox-is-not-running-when-e2b-1327-test branch from f0def1b to a9c283e Compare January 18, 2025 01:48
@0div 0div requested a review from jakubno January 18, 2025 01:55
jakubno
jakubno requested changes Jan 18, 2025
View reviewed changes
Comment thread .gitignore Outdated
Comment thread packages/js-sdk/package.json Outdated
Comment thread packages/js-sdk/package.json Outdated
Comment thread packages/js-sdk/tests/sandbox/commands/sendStdin.test.ts Outdated
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
jakubno
jakubno reviewed Jan 18, 2025
View reviewed changes
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
@0div
Merge branch 'main' of https://github.com/e2b-dev/E2B into return-err…
7cc525e 
…or-indicating-that-the-sandbox-is-not-running-when-e2b-1327-test
@0div 0div requested a review from jakubno January 18, 2025 02:54
@ValentaTomas ValentaTomas requested review from dobrac and removed request for mishushakov April 4, 2025 19:13
@ValentaTomas
Copy link
Copy Markdown
Member

ValentaTomas commented Apr 24, 2025

@0div Let's just resolve the comments and merge—we can move to integration tests later.

@0div
Merge branch 'main' of https://github.com/e2b-dev/E2B into return-err…
abd7bf5 
…or-indicating-that-the-sandbox-is-not-running-when-e2b-1327-test
@0div 0div requested a review from jakubno April 24, 2025 17:23
jakubno
jakubno requested changes Apr 25, 2025
View reviewed changes
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
Comment thread packages/js-sdk/tests/sandbox/connect.test.ts Outdated
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
@0div @jakubno
Update packages/js-sdk/tests/sandbox/host.test.ts
2c9c296 
Co-authored-by: Jakub Novák <jakub@e2b.dev>
@0div @jakubno
Update packages/js-sdk/tests/sandbox/connect.test.ts
7fc707f 
Co-authored-by: Jakub Novák <jakub@e2b.dev>
@0div @jakubno
Update packages/js-sdk/tests/sandbox/host.test.ts
86c39a4 
Co-authored-by: Jakub Novák <jakub@e2b.dev>
@0div 0div dismissed dobrac’s stale review April 25, 2025 21:40

requested change was addressed already

@0div 0div merged commit 8bfd3c0 into main Apr 25, 2025
5 checks passed
@0div 0div deleted the return-error-indicating-that-the-sandbox-is-not-running-when-e2b-1327-test branch April 25, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubno jakubno jakubno approved these changes

@dobrac dobrac Awaiting requested review from dobrac

Assignees

@0div 0div

Labels

Improvement Improvement for current functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0div @ValentaTomas @dobrac @jakubno